-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GoServer] Generate non-required parameters as pointers (nil-able) #19149
[GoServer] Generate non-required parameters as pointers (nil-able) #19149
Conversation
@phil-bugdahn-hs thanks for the PR. can you please review the test failure when you've time? |
Hi @wing328, thanks for your response. I think I have resolved the test issue. |
@phil-bugdahn-hs thanks again for the PR. Is it correct to say that this is a breaking change (without fallback)? |
Hi @phil-bugdahn-hs, I think the problem has been discussed in #16980 and #17051. You may want to review the pointers there. Is this PR trying to do what is stated in #17321? Required and Nullable are orthogonal concepts. I don't think this PR should be merged |
Closing as per disccusion in the issue. |
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming 7.6.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)This PR fixes #19169
The problem is that, using an OpenAPI spec that specifies a non-required query param, the
go-server
generator will generate the server handler taking that parameter as a value rather than a pointer. By doing this, it is not possible to tell in the handler whether the parameter was actually passed or if it is just a default value. By using a pointer the parameter value will benil
if not passed by the client. This PR should fix that issue.